chore: modernize navigation-sample and map-sample builds#26
Open
chore: modernize navigation-sample and map-sample builds#26
Conversation
This commit includes several modernization efforts and fixes: - Migrated build scripts from Groovy to Kotlin DSL (build.gradle.kts) - Implemented Version Catalogs (gradle/libs.versions.toml) for dependency management - Updated Java target to 17 - Cleaned up 16 unused dependencies (androidx, transport, joda-time, kotlin-reflect) - Updated Places SDK integration for v5 compatibility (Place.Field.DISPLAY_NAME, place.location, Places.initializeWithNewPlacesApiEnabled) - Rewrote README with clear setup instructions and added custom installAndLaunch gradle task - Ignored BOB_DATA directory
- Migrated to Kotlin DSL (build.gradle.kts) and Version Catalog - Updated Java target to 17 - Cleaned up unused legacy dependencies - Upgraded Gradle wrapper to 8.13 - Overhauled map-sample README and added installAndLaunch target
- Created NavigationSampleApplication - Moved Places API initialization and metadata extraction logic from SplashScreenActivity to NavigationSampleApplication - Registered NavigationSampleApplication in AndroidManifest.xml
- Sorted dependencies alphabetically - Synchronized versions between navigation-sample and map-sample - Corrected kotlin plugin version to 2.1.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR modernizes the build configuration and dependencies for both the
navigation-sampleandmap-sampleprojects. It migrates the Groovy build scripts to modern Kotlin DSL, implements a centralized Version Catalog, clears out legacy unused dependencies, and brings the samples up to Java 17. It also updates thenavigation-sampleto use the modern Places SDK v5 features.Changes Included
build.gradleandsettings.gradlefiles with their.gradle.ktscounterparts in both samples.gradle/libs.versions.tomlto unify dependency versions, and configureddependencyResolutionManagementinsettings.gradle.ktsfor both samples.androidx.*modules,joda-time,transportmodules, andkotlin-reflect), significantly reducing build bloat.navigation-sampleto use the new Places API fields (DISPLAY_NAME,LOCATION).SplashScreenActivityinto a properly configuredNavigationSampleApplicationclass.:app:installAndLaunchgradle targets to both samples for one-click CLI deployments.README.mdfiles to document thesecrets.propertiesAPI key setup and the new build commands.